[PATCH] D146988: [CodeGen] Enable processing of interconnected complex number operations
Nicholas Guy via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 5 08:14:16 PDT 2023
NickGuy added inline comments.
================
Comment at: llvm/test/CodeGen/AArch64/complex-deinterleaving-multiuses.ll:93
+; *p2 = (a * b) * c;
+; return d * c
+define <4 x float> @monster(<4 x float> %a, <4 x float> %b, <4 x float> %c, <4 x float> %d, ptr %p1, ptr %p2) {
----------------
dmgreen wrote:
> It is not obvious to me why d * c should prevent the rest of the tree transforming. Can you precommit the tests to show the differences in the review?
I'm not sure it's the `d * c` that's preventing it, so much as the store to %p1 (It doesn't reinterleave, so the store is deemed "outside the graph").
Though I agree, pre-commits would be useful to see the difference in the other cases
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146988/new/
https://reviews.llvm.org/D146988
More information about the llvm-commits
mailing list