[PATCH] D147431: [Assignment Tracking][SROA] Handle createFragmentExpression failure

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added inline comments.


================
Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/sroa/fail-fragment.ll:11
+; CHECK: call void @llvm.dbg.value(metadata i32 poison, metadata ![[#]], metadata !DIExpression(DW_OP_LLVM_fragment, 0, 32))
+; CHECK: call void @llvm.dbg.value(metadata i32 %{{.*}}, metadata ![[#]], metadata !DIExpression(DW_OP_LLVM_fragment, 32, 32))
+
----------------
Orlando wrote:
> StephenTozer wrote:
> > I'm curious - why is this value //not// poison? I'm assuming it's the upper fragment for the dbg.assign that couldn't be split, so I'd have thought it would be a kill location as well.
> (replying with a main-line comment)
I've added a FIXME to the test. I've landed this as-is for now to fix the assertion and live with this edge-case, I'll come back to this.


================
Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/sroa/fail-fragment.ll:14-15
+; CHECK: if.else:
+; CHECK: dbg.value(metadata i32 2, metadata ![[#]], metadata !DIExpression(DW_OP_LLVM_fragment, 0, 32))
+; CHECK: dbg.value(metadata i32 0, metadata ![[#]], metadata !DIExpression(DW_OP_LLVM_fragment, 32, 32))
+
----------------
StephenTozer wrote:
> Tiniest nit.
I turned the other CHECKS into the shorter-hand version 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147431/new/

https://reviews.llvm.org/D147431