[PATCH] D147527: [X86][mem-fold] Use the generated memory folding table

Wed Apr 5 03:02:46 PDT 2023

skan marked an inline comment as done.
skan added inline comments.

================
Comment at: llvm/lib/Target/X86/CMakeLists.txt:21
 tablegen(LLVM X86GenSubtargetInfo.inc -gen-subtarget)
-
-if (X86_GEN_FOLD_TABLES)
-  tablegen(LLVM X86GenFoldTables.inc -gen-x86-fold-tables -asmwriternum=1)
-endif()
+tablegen(LLVM X86GenFoldTables.inc -gen-x86-fold-tables -asmwriternum=1)

----------------
RKSimon wrote:
> Looks like the rest of the table is sorted?
Good question, the tables are sorted by enum of the instruction. I added a comment in https://github.com/llvm/llvm-project/blob/main/llvm/utils/TableGen/X86FoldTablesEmitter.cpp#L112 to explain this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147527/new/

https://reviews.llvm.org/D147527