[PATCH] D147599: [MLIR][OpenMP] Update OpenMPIRBuilderTest to use opaque pointers

Akash Banerjee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 5 03:00:30 PDT 2023


TIFitis added inline comments.


================
Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:4297-4302
+  // EXPECT_TRUE(
+  //     isSimpleBinaryReduction(FirstPrivatized,
+  //     cast<Instruction>(FirstArrayElemPtr)->getParent()));
+  // EXPECT_TRUE(
+  //     isSimpleBinaryReduction(SecondPrivatized,
+  //     cast<Instruction>(FirstArrayElemPtr)->getParent()));
----------------
This returns false now as `isSimpleBinaryReduction` expects a single `StoreInst` user within the block for `FirstPrivatized` and `SecondPrivatized` but with the `BitCast` Inst's removed they have two `StoreInst`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147599/new/

https://reviews.llvm.org/D147599



More information about the llvm-commits mailing list