[PATCH] D146127: [NFC][LoopVectorize] Simplify preferPredicateOverEpilogue interface

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 5 02:15:32 PDT 2023


fhahn added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:595
   /// vector loop, which can avoid the need to emit a scalar epilogue loop.
-  bool preferPredicateOverEpilogue(Loop *L, LoopInfo *LI, ScalarEvolution &SE,
-                                   AssumptionCache &AC, TargetLibraryInfo *TLI,
-                                   DominatorTree *DT,
-                                   LoopVectorizationLegality *LVL,
-                                   InterleavedAccessInfo *IAI) const;
+  bool preferPredicateOverEpilogue(TailFoldingInfo *TFI) const;
 
----------------
Is there any reason `TFI` cannot be passed as reference/const reference? This would make the interface more robust by ruling out null pointers as arguments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146127/new/

https://reviews.llvm.org/D146127



More information about the llvm-commits mailing list