[PATCH] D147512: [ARM] Convert test to opaque pointers

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 5 00:44:23 PDT 2023


dmgreen added a reviewer: ostannard.
dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

If we want something that is closer to the original, it could hoist the call into a constant:

  define void @test_inline_asm_sideeffect(%0* %call) {
    call void @bar()
    call void asm sideeffect "mov\09r7, r7\09\09@ marker", ""()
    %hoist = bitcast ptr @foo to ptr
    %1 = call ptr %hoist(ptr %call)
    ret void
  }

I agree that the new codegen shouldnt be a problem though. I think this LGTM


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147512/new/

https://reviews.llvm.org/D147512



More information about the llvm-commits mailing list