[PATCH] D147586: [amdgpu][nfc] Remove dead code associated with LDS lowering

Jon Chesterfield via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 4 17:14:08 PDT 2023


JonChesterfield created this revision.
JonChesterfield added reviewers: rampitec, arsenm, foad.
Herald added subscribers: kosarev, StephenFan, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
JonChesterfield requested review of this revision.
Herald added subscribers: llvm-commits, jplehr, sstefan1, wdng.
Herald added a reviewer: jdoerfert.
Herald added a project: LLVM.

Pass disabled since approximately D104962 <https://reviews.llvm.org/D104962> for miscompiling openmp

The functions under ReplaceConstant miscompile phis as noted in D112717 <https://reviews.llvm.org/D112717> and
have no users in tree othre than the disabled pass. It seems likely it has no
users out of tree.

Deletes the test cases associated with the disabled pass as well.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147586

Files:
  llvm/include/llvm/IR/ReplaceConstant.h
  llvm/lib/IR/ReplaceConstant.cpp
  llvm/lib/Target/AMDGPU/AMDGPU.h
  llvm/lib/Target/AMDGPU/AMDGPUReplaceLDSUseWithPointer.cpp
  llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
  llvm/lib/Target/AMDGPU/CMakeLists.txt
  llvm/lib/Target/AMDGPU/Utils/AMDGPUMemoryUtils.cpp
  llvm/lib/Target/AMDGPU/Utils/AMDGPUMemoryUtils.h
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-call-diamond-shape.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-call-selected_functions.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-call-to-declare-only-func.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-ignore-global-scope-use.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-ignore-inline-asm-call.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-ignore-kernel-only-used-lds.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-ignore-not-reachable-lds.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-ignore-small-lds.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-indirect-call-diamond-shape.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-indirect-call-selected_functions.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-indirect-call-signature-match.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-use-multiple-lds.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-use-same-lds.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-use-within-const-expr1.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-use-within-const-expr2.ll
  llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-use-within-phi-inst.ll
  llvm/utils/gn/secondary/llvm/lib/Target/AMDGPU/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147586.510972.patch
Type: text/x-patch
Size: 86773 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230405/4dcc3b4b/attachment.bin>


More information about the llvm-commits mailing list