[PATCH] D147504: [WebAssembly] `AsmTypeCheck` support to br instr
Derek Schuff via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 4 16:16:39 PDT 2023
dschuff added a reviewer: aheejin.
dschuff added a comment.
I like this idea. @aheejin is probably also a good reviewer for this.
Could `delegate` be checked similarly here too?
================
Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmTypeCheck.cpp:176
+ return false;
+ if (BrStack.size() <= static_cast<size_t>(Operand.getImm()))
+ return typeError(ErrorLoc, StringRef("br: invalid depth ") +
----------------
You're calling `Operand.getImm()` several times here, maybe pull it out into a variable?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147504/new/
https://reviews.llvm.org/D147504
More information about the llvm-commits
mailing list