[PATCH] D137707: Move "auto-init" instructions to the dominator of their users

Tue Apr 4 15:43:06 PDT 2023

ayzhao added a comment.

In D137707#4243969 <https://reviews.llvm.org/D137707#4243969>, @serge-sans-paille wrote:

> In D137707#4243796 <https://reviews.llvm.org/D137707#4243796>, @leonardchan wrote:
>
>> Hi. I think the reland broke our mac builder at https://ci.chromium.org/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.x64-host_test_only-mac-subbuild/b8784753709492580801/overview with:
>>
>>   Assertion failed: (!I.isVolatile() && "auto init instructions cannot be volatile."), function runMoveAutoInit, file llvm/lib/Transforms/Utils/MoveAutoInit.cpp, line 112.
>
> Thanks for reporting—I thought this situation wasn't possible— I'll send a fix that just skips these instructions for now.

FYI, Chrome also saw this crash as well: https://crbug.com/1430570.  I verified that your commit rGad9ad3735c4821ff4651fab7537a75b8f0bb60f8 <https://reviews.llvm.org/rGad9ad3735c4821ff4651fab7537a75b8f0bb60f8> fixes it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137707/new/

https://reviews.llvm.org/D137707