[PATCH] D147286: [FS-AFDO] Assign discriminators to pseudo probes

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 4 15:22:17 PDT 2023


hoy added a comment.

In D147286#4244544 <https://reviews.llvm.org/D147286#4244544>, @wenlei wrote:

> On second thought, if we want AFDO and CSSPGO to co-exist when FS is on, we could assign discriminators independently for probe and non-probe instructions? That way there's no more collisions in each of the two category, and when loading profile, we ignore probe for AFDO, ignore non-probe for CSSPGO?

Yes, I thought about that too. We would need two set of maps, one for each.

The profile loading should naturally work as is with the IR sample loader. The loader knows what type of profiles it sees and uses lines or probes accordingly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147286/new/

https://reviews.llvm.org/D147286



More information about the llvm-commits mailing list