[lld] d9d840c - [lld][WebAssembly] Fix stub library parsing with windows line endings

[Sam Clegg via llvm-commits]

Author: Sam Clegg
Date: 2023-04-04T11:55:01-07:00
New Revision: d9d840cdaf51a9795930750d1b91d614a3849137

URL: https://github.com/llvm/llvm-project/commit/d9d840cdaf51a9795930750d1b91d614a3849137
DIFF: https://github.com/llvm/llvm-project/commit/d9d840cdaf51a9795930750d1b91d614a3849137.diff

LOG: [lld][WebAssembly] Fix stub library parsing with windows line endings

Also, fix checking of first line in ::parse.  We can't use the
::getLines helper here since that already does comment stripping
internally.

Differential Revision: https://reviews.llvm.org/D147548

Added: 
    lld/test/wasm/Inputs/.gitattributes

Modified: 
    lld/wasm/Driver.cpp
    lld/wasm/InputFiles.cpp

Removed: 
    


################################################################################
diff  --git a/lld/test/wasm/Inputs/.gitattributes b/lld/test/wasm/Inputs/.gitattributes
new file mode 100644
index 0000000000000..6622904075b27
--- /dev/null
+++ b/lld/test/wasm/Inputs/.gitattributes
@@ -0,0 +1,3 @@
+# ensures that we test parsing of stub libraries that contain
+# windows line endings
+libstub.so text eol=crlf

diff  --git a/lld/wasm/Driver.cpp b/lld/wasm/Driver.cpp
index 7ce221e1f6634..3867b9cb3c37d 100644
--- a/lld/wasm/Driver.cpp
+++ b/lld/wasm/Driver.cpp
@@ -280,7 +280,7 @@ void LinkerDriver::addFile(StringRef path) {
     files.push_back(createObjectFile(mbref));
     break;
   case file_magic::unknown:
-    if (mbref.getBuffer().starts_with("#STUB\n")) {
+    if (mbref.getBuffer().starts_with("#STUB")) {
       files.push_back(make<StubFile>(mbref));
       break;
     }

diff  --git a/lld/wasm/InputFiles.cpp b/lld/wasm/InputFiles.cpp
index 2d9768c768f29..fef5604572178 100644
--- a/lld/wasm/InputFiles.cpp
+++ b/lld/wasm/InputFiles.cpp
@@ -691,12 +691,16 @@ StringRef strip(StringRef s) {
 }
 
 void StubFile::parse() {
-  bool first = false;
+  bool first = true;
+
+  SmallVector<StringRef> lines;
+  mb.getBuffer().split(lines, '\n');
+  for (StringRef line : lines) {
+    line = line.trim();
 
-  for (StringRef line : args::getLines(mb)) {
     // File must begin with #STUB
     if (first) {
-      assert(line == "#STUB\n");
+      assert(line == "#STUB");
       first = false;
     }
 
@@ -713,10 +717,10 @@ void StubFile::parse() {
     symbolDependencies[sym] = {};
 
     while (rest.size()) {
-      StringRef first;
-      std::tie(first, rest) = rest.split(',');
-      first = strip(first);
-      symbolDependencies[sym].push_back(first);
+      StringRef dep;
+      std::tie(dep, rest) = rest.split(',');
+      dep = strip(dep);
+      symbolDependencies[sym].push_back(dep);
     }
   }
 }