[PATCH] D147096: AMDGPU: Created a sub-register class for the return address operand in the tail call return instruction

Tue Apr 4 11:52:24 PDT 2023

bjope added a comment.

In D147096#4243945 <https://reviews.llvm.org/D147096#4243945>, @cfang wrote:

> In D147096#4243891 <https://reviews.llvm.org/D147096#4243891>, @cfang wrote:
>
>> In D147096#4238464 <https://reviews.llvm.org/D147096#4238464>, @aaron.ballman wrote:
>>
>>> In D147096#4235978 <https://reviews.llvm.org/D147096#4235978>, @bjope wrote:
>>>
>>>> In case you haven't noticed, the expensive checks build bots started to fail (after this patch afaict).
>>>> See https://lab.llvm.org/buildbot/#/builders/16  (or more specific this first fail when testing this patch https://lab.llvm.org/buildbot/#/builders/16/builds/45691 )
>>>
>>> I also noticed these bots have been down for over 24 hours, so I've reverted this in ec1f5b947e6c197c0d61cc0a5c7a219ac4873614 <https://reviews.llvm.org/rGec1f5b947e6c197c0d61cc0a5c7a219ac4873614> to hopefully get the bots back to green.
>>
>> I am not sure what happened. But the test actually passed on my end. So I re-commit it as it is.
>
> Am I missing anything in the cmake options?  I see it still fails:
> cmake -GNinja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_COMPILER=/opt/rocm/llvm/bin/clang++ -DCMAKE_C_COMPILER=/opt/rocm/llvm/bin/clang  -DLLVM_ENABLE_PROJECTS="clang;lld;compiler-rt" -DLLVM_TARGETS_TO_BUILD="AMDGPU;X86" -DLLVM_USE_LINKER=lld ../llvm

Expensive checks are enabled by using

  -DLLVM_ENABLE_EXPENSIVE_CHECKS=ON

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147096/new/

https://reviews.llvm.org/D147096