[PATCH] D146749: [CodeGen] Fix nomerge attribute not working in tail calls.

Zequan Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 4 11:43:44 PDT 2023


zequanwu added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/nomerge.ll:50
 
+define void @foo_tail(i1 %i) {
+; CHECK-LABEL: foo_tail:
----------------
jrtc27 wrote:
> zequanwu wrote:
> > jrtc27 wrote:
> > > Precommit all these?
> > Can you elaborate on what does precommit mean? Do you mean commit on foo_tail functions without CHECKs before this patch?
> Commit the tests with CHECK lines generated from the compiler without this codegen change applied
Landed at https://reviews.llvm.org/rG321d02cc6b6a1116c227c172249b5cacf4d0deba. Rebased this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146749/new/

https://reviews.llvm.org/D146749



More information about the llvm-commits mailing list