[PATCH] D147529: [DWARFLinkerParallel] Add StringsForEmission class.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: llvm/include/llvm/DWARFLinkerParallel/StringsForEmission.h:22
+/// translates string if necessary, assigns index and offset, keeps in order.
+class StringsForEmission {
+public:
----------------
Should we call this `StringTable`?


================
Comment at: llvm/include/llvm/DWARFLinkerParallel/StringsForEmission.h:32
+  /// \returns updated string entry.
+  StringEntry *addString(StringEntry *String) {
+    // Translate string if necessary.
----------------



================
Comment at: llvm/include/llvm/DWARFLinkerParallel/StringsForEmission.h:71
+protected:
+  // List of strings for emission.
+  StringsVector StringEntriesForEmission;
----------------



================
Comment at: llvm/include/llvm/DWARFLinkerParallel/StringsForEmission.h:74
+
+  // String pool for the translated strings.
+  StringPool &Strings;
----------------



================
Comment at: llvm/include/llvm/DWARFLinkerParallel/StringsForEmission.h:77
+
+  // Translator for the strings.
+  std::function<StringRef(StringRef)> StringsTranslator;
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147529/new/

https://reviews.llvm.org/D147529