[PATCH] D147348: [MergedLoadStoreMotion] Merge stores with conflicting value types

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 4 09:52:19 PDT 2023


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/include/llvm/IR/Instruction.h:769
+  /// if we are comparing loads, then haveSameSpecialState would compare check the alignments.
+  /// @returns true if the specific instruction has the same opcde specific characteristics as the current one.
+  /// Determine if one instruction has the same state as another.
----------------
opcde -> opcode

I also suspect this doesn't follow clang-format due to overlong comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147348/new/

https://reviews.llvm.org/D147348



More information about the llvm-commits mailing list