[PATCH] D147499: [dsymutil] Improve error with invalid reproducer args

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 4 09:26:11 PDT 2023


JDevlieghere added a comment.

I'm wondering if we shouldn't just hide the `Use` mode from the user and make that an implementation detail. The help string for the `--reproducer` option already says:

> Specify the reproducer generation mode.

Limiting the option to /generation/ modes (GenerateOnExit, GenerateOnCrash and Off) makes sense to me conceptually.

The help string for `--use-reproducer` is also wrong:

> Use the object files from the given reproducer path. Alias for --reproducer=Use.

The flag is not an alias but rather implies `--reproducer=Use` which could be an implementation detail.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147499/new/

https://reviews.llvm.org/D147499



More information about the llvm-commits mailing list