[PATCH] D143938: [VPlan] Compute costs for plans directly after construction (WIP).

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 4 09:06:26 PDT 2023


fhahn marked an inline comment as done.
fhahn added a comment.

Ping. I think the latest version should be cleaned up and ready for review.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationPlanner.h:388
+
+  bool isMoreProfitable(const VectorizationFactor &A,
+                        const VectorizationFactor &B) const;
----------------
tschuett wrote:
> Could you add a comment `/// Returns true when Factor A is more profitable than Factor B` ? I was unclear about the direction A v.s B.
Thanks, added the comment!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143938/new/

https://reviews.llvm.org/D143938



More information about the llvm-commits mailing list