[PATCH] D147523: [ARM] Fix VMOVSR pattern requirements

Mikhail Maltsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 4 08:45:42 PDT 2023


This revision was automatically updated to reflect the committed changes.
Closed by commit rG0ee891fe2e57: [ARM] Fix VMOVSR pattern requirements (authored by miyuki).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147523/new/

https://reviews.llvm.org/D147523

Files:
  llvm/lib/Target/ARM/ARMInstrVFP.td
  llvm/test/CodeGen/Thumb2/float-ops-vmovsr-nofp-xo.ll


Index: llvm/test/CodeGen/Thumb2/float-ops-vmovsr-nofp-xo.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/Thumb2/float-ops-vmovsr-nofp-xo.ll
@@ -0,0 +1,30 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 2
+; RUN: llc < %s -mtriple=thumbv8.1m.main-none-eabihf -mattr=+mve,+execute-only | FileCheck %s
+
+declare void @ext_fn(float)
+
+define void @test1() {
+; CHECK-LABEL: test1:
+; CHECK:       @ %bb.0: @ %entry
+; CHECK-NEXT:    .save {r7, lr}
+; CHECK-NEXT:    push {r7, lr}
+; CHECK-NEXT:    movs r0, #0
+; CHECK-NEXT:    vmov s0, r0
+; CHECK-NEXT:    bl ext_fn
+; CHECK-NEXT:    pop {r7, pc}
+entry:
+  call void @ext_fn(float 0.000000e+00)
+  ret void
+}
+
+define float @test2() {
+; CHECK-LABEL: test2:
+; CHECK:       @ %bb.0: @ %entry
+; CHECK-NEXT:    movw r0, #63911
+; CHECK-NEXT:    movt r0, #16673
+; CHECK-NEXT:    vmov s0, r0
+; CHECK-NEXT:    bx lr
+entry:
+  ret float 0x40243F34E0000000
+}
+
Index: llvm/lib/Target/ARM/ARMInstrVFP.td
===================================================================
--- llvm/lib/Target/ARM/ARMInstrVFP.td
+++ llvm/lib/Target/ARM/ARMInstrVFP.td
@@ -1201,7 +1201,7 @@
   let D = VFPNeonDomain;
 }
 } // isMoveReg
-def : Pat<(arm_vmovsr GPR:$Rt), (VMOVSR GPR:$Rt)>, Requires<[HasVFP2, UseVMOVSR]>;
+def : Pat<(arm_vmovsr GPR:$Rt), (VMOVSR GPR:$Rt)>, Requires<[HasFPRegs, UseVMOVSR]>;
 
 let hasSideEffects = 0 in {
 def VMOVRRD  : AVConv3I<0b11000101, 0b1011,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147523.510822.patch
Type: text/x-patch
Size: 1526 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230404/4462b9f0/attachment.bin>


More information about the llvm-commits mailing list