[PATCH] D147526: [sanitizers] Simplify Explainer about dyld and weak overrides on Darwin. (NFC)

[Roy Sundahl via Phabricator via llvm-commits]

rsundahl created this revision.
Herald added a project: All.
rsundahl requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Presenting more than one way to satisfy the single-weak-ref requirement leads to
confusing messaging for the end user. Use the introduction of a single unused
weak variable as the preferred solution. This differential modifies D146745 <https://reviews.llvm.org/D146745>.

rdar://103453678


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147526

Files:
  llvm/docs/ReleaseNotes.rst


Index: llvm/docs/ReleaseNotes.rst
===================================================================
--- llvm/docs/ReleaseNotes.rst
+++ llvm/docs/ReleaseNotes.rst
@@ -245,16 +245,10 @@
   only consider symbols in other mach-o modules which themselves contain at
   least one weak symbol. A consequence is that if your program or dylib contains
   an intended override of a weak symbol, then it must contain at least one weak
-  symbol as well for the override to be effective. That weak symbol may be the
-  intended override itself, an otherwise usused weak symbol added solely to meet
-  the requirement, or an existing but unrelated weak symbol.
-
-    Examples:
-      __attribute__((weak)) const char * __asan_default_options(void) {...}
+  symbol as well for the override to take effect.
 
+    Example:
       __attribute__((weak,unused)) unsigned __enableOverrides;
-      
-      __attribute__((weak)) bool unrelatedWeakFlag;
 
 Other Changes
 -------------


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147526.510773.patch
Type: text/x-patch
Size: 968 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230404/4dcabf4a/attachment.bin>