[PATCH] D147493: [ELF] Cap parallel::strategy to 8 cores when --threads= is unspecified

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 4 03:05:27 PDT 2023


peter.smith added a comment.

> How about turning it into a warning instead:
> The parallelism is higher than 8 and --threads= was not specified.

I'd prefer something in the verbose output, such as "Setting maximum parallelism to 8, use --threads=<threads> to increase". I think a warning could be too noisy in this case and would force most people to add an extra parameter to the link to silence it.

Code changes LGTM, I'd like to see if I can get some data on a non-X86 machine to back the decision up. Will see if I can get some time on a high core count AArch64 server to get some data. As I'm expecting a similar result if I can't get it in time, no objections.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147493/new/

https://reviews.llvm.org/D147493



More information about the llvm-commits mailing list