[PATCH] D147485: [Object] Refactor build ID parsing into Object lib.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/lib/Object/BuildID.cpp:21-22
 
-namespace llvm {
-namespace object {
+using namespace llvm;
+using namespace llvm::object;
 
----------------
Why have you changed this?


================
Comment at: llvm/test/DebugInfo/symbolize-filter-markup-parse-fields.test:21
 CHECK: error: expected build ID; found ''
-CHECK: error: expected build ID; found '0'
+CHECK-NOT: '0'
 CHECK-NOT: '0xff'
----------------
This check feels a bit fragile. Also, why has there been a behaviour change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147485/new/

https://reviews.llvm.org/D147485