[PATCH] D110900: Triple: Add RedHat vendor

Mon Apr 3 20:23:05 PDT 2023

MaskRay added inline comments.

================
Comment at: llvm/include/llvm/TargetParser/Triple.h:579
+    case Triple::UnknownEnvironment:
+        return getVendor() == RedHat;
+    default:
----------------
tstellar wrote:
> aaronpuchert wrote:
> > hvdijk wrote:
> > > In D110900#4160169 you suggested that this should be done for SUSE as well, do you still think so?
> > Yes, in fact we ship with a [patch](https://build.opensuse.org/package/view_file/devel:tools:compiler/llvm16/llvm-suse-implicit-gnu.patch) that does that in openSUSE now. It mostly works without that, but some things were missing, see D110900#4160110.
> > 
> > If we can agree on this, I'd open a separate change on top of this for `SUSE`. (Unless @tstellar would like to include it right away.)
> I think we should add SUSE here in a separate change.
> In D110900#4160169 you suggested that this should be done for SUSE as well, do you still think so?

@hvdijk Your suggestion may be this: "
A possibly radical alternative suggestion: could we instead change the way the GCC installation to use is determined"

Can you elaborate? I agree that decreasing the number of filesystem stats is preferable...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110900/new/

https://reviews.llvm.org/D110900