[PATCH] D147371: [libunwind][test] Add test to check for unw_resume()
Limin Zhang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 3 20:09:29 PDT 2023
Ami-zhang added inline comments.
================
Comment at: libunwind/test/unw_resume.pass.cpp:13
+// clang-format off
+// REQUIRES: linux && (target={{aarch64-.+}} || target={{loongarch64-.+}} || target={{s390x-.+}} || target={{x86_64-.+}})
+
----------------
arichardson wrote:
> This is overly restrictive, the test looks like it should work anywhere so there should instead be xfails for the cases that are failing.
>
> I know this is what other tests are doing but those should also be changed IMO.
Updated it.
Thanks for your suggestion.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147371/new/
https://reviews.llvm.org/D147371
More information about the llvm-commits
mailing list