[compiler-rt] 10b11aa - [scudo] Temporarily disable the build of Timer.

Chia-hung Duan via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 3 18:05:03 PDT 2023


Author: Chia-hung Duan
Date: 2023-04-04T01:04:24Z
New Revision: 10b11aadc54f0eed2f05214c0d627d16f01457a9

URL: https://github.com/llvm/llvm-project/commit/10b11aadc54f0eed2f05214c0d627d16f01457a9
DIFF: https://github.com/llvm/llvm-project/commit/10b11aadc54f0eed2f05214c0d627d16f01457a9.diff

LOG: [scudo] Temporarily disable the build of Timer.

The placeholder was %llu while merged but it may cause problem on some
platforms that enable -Wformat. It was incorrect changed to %lu which
cause the test failure because string_utils doesn't support %lu. Will
bring this back after we fix the placeholder.

Differential Revision: https://reviews.llvm.org/D147490

Added: 
    

Modified: 
    compiler-rt/lib/scudo/standalone/CMakeLists.txt
    compiler-rt/lib/scudo/standalone/tests/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/scudo/standalone/CMakeLists.txt b/compiler-rt/lib/scudo/standalone/CMakeLists.txt
index 6fcd4deddf716..86d4a47a391bc 100644
--- a/compiler-rt/lib/scudo/standalone/CMakeLists.txt
+++ b/compiler-rt/lib/scudo/standalone/CMakeLists.txt
@@ -85,7 +85,9 @@ set(SCUDO_HEADERS
   stack_depot.h
   stats.h
   string_utils.h
-  timing.h
+  # TODO(chiahungduan): Temporarily disable the timer because of the print
+  # of u64 has incorrect placeholder.
+  # timing.h
   tsd_exclusive.h
   tsd_shared.h
   tsd.h
@@ -108,7 +110,9 @@ set(SCUDO_SOURCES
   report.cpp
   rss_limit_checker.cpp
   string_utils.cpp
-  timing.cpp
+  # TODO(chiahungduan): Temporarily disable the timer because of the print
+  # of u64 has incorrect placeholder.
+  # timing.cpp
   )
 
 # Enable the necessary instruction set for scudo_crc32.cpp, if available.

diff  --git a/compiler-rt/lib/scudo/standalone/tests/CMakeLists.txt b/compiler-rt/lib/scudo/standalone/tests/CMakeLists.txt
index 335e4b7dbd899..3bb707d90a611 100644
--- a/compiler-rt/lib/scudo/standalone/tests/CMakeLists.txt
+++ b/compiler-rt/lib/scudo/standalone/tests/CMakeLists.txt
@@ -105,7 +105,9 @@ set(SCUDO_UNIT_TEST_SOURCES
   size_class_map_test.cpp
   stats_test.cpp
   strings_test.cpp
-  timing_test.cpp
+  # TODO(chiahungduan): Temporarily disable the timer test because of the print
+  # of u64 has incorrect placeholder.
+  # timing_test.cpp
   tsd_test.cpp
   vector_test.cpp
   scudo_unit_test_main.cpp


        


More information about the llvm-commits mailing list