[PATCH] D147426: [SmallVector] Add an explicit SmallVector(size_t Size) constructor.
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 3 13:22:59 PDT 2023
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG475dd6f626ee: [SmallVector] Add an explicit SmallVector(size_t Size) constructor. (authored by craig.topper).
Changed prior to commit:
https://reviews.llvm.org/D147426?vs=510409&id=510584#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147426/new/
https://reviews.llvm.org/D147426
Files:
llvm/include/llvm/ADT/SmallVector.h
llvm/unittests/ADT/SmallVectorTest.cpp
Index: llvm/unittests/ADT/SmallVectorTest.cpp
===================================================================
--- llvm/unittests/ADT/SmallVectorTest.cpp
+++ llvm/unittests/ADT/SmallVectorTest.cpp
@@ -171,6 +171,11 @@
V.resize(42);
}
+TEST(SmallVectorTest, ConstructNonCopyableTest) {
+ SmallVector<NonCopyable, 0> V(42);
+ EXPECT_EQ(V.size(), 42);
+}
+
// Assert that v contains the specified values, in order.
template <typename VectorT>
void assertValuesInOrder(VectorT &v, size_t size, ...) {
Index: llvm/include/llvm/ADT/SmallVector.h
===================================================================
--- llvm/include/llvm/ADT/SmallVector.h
+++ llvm/include/llvm/ADT/SmallVector.h
@@ -1206,7 +1206,12 @@
this->destroy_range(this->begin(), this->end());
}
- explicit SmallVector(size_t Size, const T &Value = T())
+ explicit SmallVector(size_t Size)
+ : SmallVectorImpl<T>(N) {
+ this->resize(Size);
+ }
+
+ SmallVector(size_t Size, const T &Value)
: SmallVectorImpl<T>(N) {
this->assign(Size, Value);
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147426.510584.patch
Type: text/x-patch
Size: 1057 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230403/9cfde05f/attachment.bin>
More information about the llvm-commits
mailing list