[PATCH] D146759: [clang][ExtractAPI] Handle Declaration fragments for properties to not include spurious additional attributes.

Mon Apr 3 13:08:49 PDT 2023

zixuw added a comment.

Hi Usman! This is looking very good and complete now! Thanks for taking the time to learn and fix this.

nit: it's a good practice to keep the commit message title short (<70 chars) and explain a bit more in the message body. Also good to mention the issue if there is one. For example:

  [ExtractAPI] Remove extra attributes in property declaration fragments

  Use `getPropertyAttributesAsWritten` instead of `getPropertyAttributes`
  to get property attributes actually specified in the source code.
  Resolves issue #61478.

  Differential Revision: https://reviews.llvm.org/D146759

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146759/new/

https://reviews.llvm.org/D146759