[PATCH] D144233: [amdgpu] Implement dynamic LDS accesses from non-kernel functions

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with nits



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp:885
         // Either used no LDS, or the LDS it used was all in the module struct
+        // or dyanmically sized
         continue;
----------------
Typo ‘dyanmically’


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp:955
+    std::string VarName =
+        Twine("llvm.amdgcn." + func->getName() + ".dynlds").str();
+
----------------
The GlobalVariable constructor uses Twine, you don’t need to convert it to std::string here 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144233/new/

https://reviews.llvm.org/D144233