[PATCH] D147336: [IVDescriptors] Add pointer InductionDescriptors with non-constant strides (try 2)

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 3 10:48:25 PDT 2023


reames added a comment.

Ok, it's pretty clear the scope of this is much much broader than I'd realized.  I'm going to change tack here, and come at this from a different angle.  I'm going to re-frame this patch as generalizing IVDescriptors, and adding an off-by-default option in LV to allow vectorization of such IVs.  This keeps the status quo in LV while getting the IVDescriptor code landed.

I do not intend for this flag to be supported long term.  I need it to write a test corpus that covers the various optimization quality issues reported above.  Doing it this way also allows me to separate the second functional issue into it's own review - I've dug into that one a bit, and it's looking a bit annoying.

My thinking is now that we need to work through result quality for strided IVs (i.e. using gathers or strided accesses where available), before returning to this.  I'm hoping to be able to stage these as individual commits.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147336/new/

https://reviews.llvm.org/D147336



More information about the llvm-commits mailing list