[PATCH] D147415: [MachineOutliner] Avoid outlining XRay pseudo-instructions
duk via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 3 10:48:16 PDT 2023
duck-37 planned changes to this revision.
duck-37 added inline comments.
================
Comment at: llvm/test/CodeGen/AArch64/machine-outliner-patchable-exit.mir:5
+...
+---
+name: foo1
----------------
paquette wrote:
> Can you add testcases for the other XRay opcodes too?
Sure, but it's important to note that the test case for PATCHABLE_FUNCTION_ENTER won't fail
... outside of ARM32, where `isMBBSafeToOutlineFrom` is overriden without a call to the base class. I'll add a test for this there, and then submit a patch to refactor `isMBBSafeToOutlineFrom` as well.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147415/new/
https://reviews.llvm.org/D147415
More information about the llvm-commits
mailing list