[PATCH] D144565: dwp check overflow

[Alexander Yermolovich via Phabricator via llvm-commits]

ayermolo added inline comments.


================
Comment at: llvm/lib/DWP/DWP.cpp:861
+      if (Error Err = 
+          addAllTypesFromDWP(Out, TypeIndexEntries, TUIndex, OutSection,
+                            TypeInputSection, CurEntry,
----------------
zhuna8616 wrote:
> ayermolo wrote:
> > Is this because of tabs?
> Is this a format issue? Should I make it like this:
> 
> ```
>       if (Error Err = addAllTypesFromDWP(Out, TypeIndexEntries, TUIndex, OutSection,
>                                          TypeInputSection, CurEntry,
>                                          ContributionOffsets[TypesContributionIndex],
>                                          TypesContributionIndex))
> ```
> 
> Or should I add a tab to the left of `addAllTypesFromDWP`?
Just wondering if you have tab enabled in your IDE. From what I remember at least on windows VS it's the default, and you need to change it to 4 spaces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144565/new/

https://reviews.llvm.org/D144565