[PATCH] D147363: [AMDGPU] Add target hook to isGlobalMemoryObject

[Jeffrey Byrnes via Phabricator via llvm-commits]

jrbyrnes added a comment.

If the approach is agreed upon, it LGTM.

FWIW, MI.hasUnmodeledSideEffects seems to be used to stop other passes in CodeGen. Even if these passes are currently irrelevant to the IGLP, we will need to be sure any future reliance on this accounts for IGLP (if we remove sideeffects from MI)



================
Comment at: llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp:1540
+bool GCNScheduleDAGMILive::isGlobalMemoryObject(MachineInstr *MI) {
+  if (isIGLPInstr(MI))
+    return false;
----------------
can you combine the logic?


================
Comment at: llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp:1559
+bool GCNPostScheduleDAGMILive::isGlobalMemoryObject(MachineInstr *MI) {
+  if (isIGLPInstr(MI))
+    return false;
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147363/new/

https://reviews.llvm.org/D147363