[PATCH] D147424: [MC][AMDGPU] Warn when disassembling a v_cmpx with non-exec destination

Anshil Gandhi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 3 09:29:36 PDT 2023


gandhi21299 added a comment.

In D147424#4239901 <https://reviews.llvm.org/D147424#4239901>, @foad wrote:

> This is pretty much the same as D133334 <https://reviews.llvm.org/D133334> right?
>
> I'm still not too happy about emitting warnings without using proper diagnostics. The reason is that when the disassembler is being used as a library then it's probably not appropriate for it just to write warnings to stderr.

Yes, it's almost the same. I was facing some rebase difficulties so I created a new revision. I am in favor of having a diagnostics infrastructure in disassembler for emitting warnings/errors as well. I will work on it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147424/new/

https://reviews.llvm.org/D147424



More information about the llvm-commits mailing list