[PATCH] D146749: [CodeGen] Fix nomerge attribute not working in tail calls.

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6301
       }
-      // Copy the object to parameter save area if it can not be entirely passed 
+      // Copy the object to parameter save area if it can not be entirely passed
       // by registers.
----------------
Leave whitespace not in the code you're touching alone


================
Comment at: llvm/test/CodeGen/AArch64/nomerge.ll:30
 ; CHECK-NEXT:    b bar
+
 entry:
----------------
Where did this come from?


================
Comment at: llvm/test/CodeGen/AArch64/nomerge.ll:50
 
+define void @foo_tail(i1 %i) {
+; CHECK-LABEL: foo_tail:
----------------
Precommit all these?


================
Comment at: llvm/test/CodeGen/ARM/nomerge.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 2
 ; RUN: llc < %s -mtriple=arm -o - | FileCheck %s
----------------
This conversion should likely be precommitted to highlight the actual diff


================
Comment at: llvm/test/CodeGen/RISCV/nomerge.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 2
 ; RUN: llc < %s -mtriple=riscv64 -o - | FileCheck %s
----------------
Ugh, D79537 added this without getting a RISC-V contributor's review (Craig wasn't yet one)... like the others, convert this separately


================
Comment at: llvm/test/CodeGen/RISCV/nomerge.ll:8
+; CHECK-NEXT:    addi sp, sp, -16
+; CHECK-NEXT:    .cfi_def_cfa_offset 16
+; CHECK-NEXT:    sd ra, 8(sp) # 8-byte Folded Spill
----------------
These tests could benefit from nounwind to trim irrelevant CFI directives


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146749/new/

https://reviews.llvm.org/D146749