[PATCH] D146325: [PowerPC] Add statistics to show the number of entries in the TOC.

Mon Apr 3 08:03:46 PDT 2023

amyk added inline comments.

================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:2900
+    MCSymbol *TOCEntry =
+        lookUpOrCreateTOCEntry(TypeInfoSym, TOCType_GlobalInternal);
     const MCSymbol *TOCBaseSym =
----------------
stefanp wrote:
> amyk wrote:
> > I might be missing something but how do we know that the type will be `TOCType_GlobalInternal`?
> > I realized I am not quite sure what the `TType` means. 
> The `TType` that we emit here is used for Exception Handling on AIX.
> I had originally assumed that exception handling could only be local but after you asked the question I looked into it some more and realized that I was wrong. Therefore, I've fixed this code to check if this is an internal or external symbol.
Thanks Stefan! The change you made LGTM. Thanks for looking into this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146325/new/

https://reviews.llvm.org/D146325