[PATCH] D147397: [WebAssembly] Fix selection of global calls

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 3 07:57:40 PDT 2023


tlively accepted this revision.
tlively added a comment.

LGTM % comment clarification.



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelDAGToDAG.cpp:254
+      // symbol (which will be lowered to a library function), or an alias of
+      // it. If the target is not a function/external symbol, not removing the
+      // wrapper will cause it to be loaded with a CONST instruction and be
----------------
What is "it" at the beginning of this first sentence? Also, the second sentence has a lot of double (or triple?) negatives, so it slightly confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147397/new/

https://reviews.llvm.org/D147397



More information about the llvm-commits mailing list