[PATCH] D144233: [amdgpu] Implement dynamic LDS accesses from non-kernel functions

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp:188
+bool isDynamicLDS(const GlobalVariable *GV) {
+  if (AMDGPU::isLDSVariableToLower(*GV)) {
+    if (!GV->hasInitializer()) {
----------------
arsenm wrote:
> I think this is call is only adding confusion. Just GV->getAddressSpace() == local && !GV->hasInitializer?
> 
> I also don't think checking the initializer is quite right. AMDGPUPromoteAlloca checks for GV->hasExternalLinkage() && AllocSize == 0. 
Thanks! There's some dead code in utils to remove as well, fixing


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144233/new/

https://reviews.llvm.org/D144233