[PATCH] D147078: [LICM][BPF] Disable hoistMinMax() optimization for BPF target

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 3 04:31:25 PDT 2023


fhahn added a comment.

I think adding a flag doesn't address the concern that were raised about making this behaviour target-dependent in general. I don't feel super strongly about the issue, so if other people in general think we should add a way to disable this transform, this is fine with me.

But I think it would be better to undo the transform if needed. There is no guarantee that LICM is the only source of this pattern and it's generally considered that backends should support any form of valid LLVM IR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147078/new/

https://reviews.llvm.org/D147078



More information about the llvm-commits mailing list