[PATCH] D147420: [X86] Support AMX Complex instructions

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: clang/docs/ReleaseNotes.rst:320-321
 
+- Add ISA of ``AMX-COMPLEX`` which support ``_tile_cmmimfp16ps`` and
+  ``_tile_cmmrlfp16ps``.
+
----------------
`support` -> `supports`

It's better to mention `tcmmimfp16ps` and `tcmmrlfp16ps` rather then intrinsics.


================
Comment at: clang/lib/Basic/Targets/X86.cpp:922
       .Case("amx-tile", true)
+      .Case("amx-complex", true)
       .Case("avx", true)
----------------
This needs to keep in order too.


================
Comment at: clang/lib/Basic/Targets/X86.cpp:1024
       .Case("amx-tile", HasAMXTILE)
+      .Case("amx-complex", HasAMXCOMPLEX)
       .Case("avx", SSELevel >= AVX)
----------------
ditto.


================
Comment at: llvm/test/CodeGen/X86/AMX/amxcomplex-intrinsics.ll:3
+
+; RUN: llc < %s -O0 -mtriple=x86_64-unknown-unknown -mattr=+amx-tile,+amx-complex --show-mc-encoding | FileCheck %s
+
----------------
No need for `-O0`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147420/new/

https://reviews.llvm.org/D147420