[PATCH] D146774: [AMDGPU][IGLP] WIP/Demo: Add rules to SchedGroups

Austin Kerbow via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 2 19:01:49 PDT 2023


kerbowa added a comment.

I like the general approach. It seems like things could get unwieldy with larger SchedGroups. You would need to have lots of checks vs Collection.size() which could be somewhat hard to work with.

Maybe allowing rules to look into other already built SchedGroups could be helpful? That way you could avoid some of the Collection.size() stuff.

Have you tried to implement Po Yen's proposal, or do you have a general idea about how this patch may try to implement it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146774/new/

https://reviews.llvm.org/D146774



More information about the llvm-commits mailing list