[PATCH] D147420: [X86] Support AMX Complex instructions

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:4665-4666
 def mno_amx_tile : Flag<["-"], "mno-amx-tile">, Group<m_x86_Features_Group>;
+def mamx_complex : Flag<["-"], "mamx-complex">, Group<m_x86_Features_Group>;
+def mno_amx_complex : Flag<["-"], "mno-amx-complex">, Group<m_x86_Features_Group>;
 def mcmpccxadd : Flag<["-"], "mcmpccxadd">, Group<m_x86_Features_Group>;
----------------
Move before `mamx_fp16` to keep order.


================
Comment at: clang/lib/Headers/immintrin.h:542
+#if !(defined(_MSC_VER) || defined(__SCE__)) || __has_feature(modules) ||      \
+    defined(__AMXCOMPLEX__) || defined(__M_INTRINSIC_PROMOTE__)
+#include <amxcomplexintrin.h>
----------------
Remove


================
Comment at: llvm/include/llvm/TargetParser/X86TargetParser.def:172
 X86_FEATURE       (AMX_TILE,        "amx-tile")
+X86_FEATURE       (AMX_COMPLEX,     "amx-complex")
 X86_FEATURE       (CLDEMOTE,        "cldemote")
----------------
ditto.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147420/new/

https://reviews.llvm.org/D147420