[PATCH] D147102: [M68k] Add `TRAP`, `TRAPV`, `BKPT`, `ILLEGAL` instructions

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 1 19:36:13 PDT 2023


myhsu added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kInstrControl.td:356
           (ADDX32dd MxDRD32:$op, (MOV32ri 0))>;
+
+def TRAP : MxInst<(outs), (ins Mxi8imm:$vect), "trap\t$vect", []> {
----------------
nit: could you add a simple banner here like
```
//===------------===//
// Trap / Breakpoint
//===------------===//
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147102/new/

https://reviews.llvm.org/D147102



More information about the llvm-commits mailing list