[PATCH] D119049: [LLD] Allow usage of LLD as a library

Sat Apr 1 07:36:35 PDT 2023

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Looks great!

================
Comment at: lld/tools/lld/lld.cpp:64

+LLD_HAS_DRIVER(coff);
+LLD_HAS_DRIVER(elf);
----------------
aganea wrote:
> MaskRay wrote:
> > Latest clang gives warnings in a `-DLLD_DEFAULT_LD_LLD_IS_MINGW=on` build.
> > ```
> > /home/maskray/llvm/lld/tools/lld/lld.cpp:64:21: warning: extra ';' outside of a function is incompatible with C++98 [-Wc++98-compat-extra-semi]
> > LLD_HAS_DRIVER(coff);
> >                     ^
> > ```
> Hmm I don't see this with latest patch, would you have a chance to check again if it's still there?
The warning goes away! Thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119049/new/

https://reviews.llvm.org/D119049