[PATCH] D147373: [VectorCombine] fold vector reverse loops

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

Why is the test file called reverse-loop.ll when it doesn't involve loops?



================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:357
+  if (!C->getSplatValue())
+    return false;
+
----------------
Why does this need to be a splat? If its constant we can just constant fold with the outer shuffle


================
Comment at: llvm/test/Transforms/VectorCombine/reverse-loop.ll:141
+  ret <8 x i1> %t3
+}
----------------
Add negative test coverage that checks for length changing shuffles?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147373/new/

https://reviews.llvm.org/D147373