[PATCH] D144936: [SPARC][IAS] Recognize more SPARCv9 instructions/pseudoinstructions

[Koakuma via Phabricator via llvm-commits]

koakuma added inline comments.


================
Comment at: llvm/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp:667
+  if (!is64Bit())
+    return Error(IDLoc, "setx is only available in 64-bit mode");
+
----------------
jrtc27 wrote:
> Shouldn't this be impossible due to the predicate, and thus be an assert?
Probably just me misunderstanding it but during testing I found out that even with 32-bit `-mtriple=sparc` it still recognizes SETX anyway, that's why I'm putting the condition as a normal error instead of an assert.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144936/new/

https://reviews.llvm.org/D144936