[PATCH] D147305: [LoongArch] Optimize multiplication with immediates

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 31 19:30:16 PDT 2023


benshi001 added a comment.

In D147305#4237944 <https://reviews.llvm.org/D147305#4237944>, @SixWeining wrote:

> Thanks for the improvements.
> So this is only for the `case 2` mentioned by @xen0n, right? Seems that the test for `81` is missing.
>
> Will `case 1` and `case 3` be handled later?

Thanks for your comments.

1. The missing case 81 is added.
2. I will implement `case 1` and `case 3` later in another patch. BTW: Total amount of these two cases is small, and they even have redundant values with `case 2`, so how about implementing them without `foreach`, just standalone `Pat` one by one ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147305/new/

https://reviews.llvm.org/D147305



More information about the llvm-commits mailing list