[llvm] 71dbd86 - [llvm-mc] Fix line_end_with_space.test

Aiden Grossman via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 31 16:27:13 PDT 2023


Author: Aiden Grossman
Date: 2023-03-31T23:27:08Z
New Revision: 71dbd864f19f8b372f857b5322d3324240a17b89

URL: https://github.com/llvm/llvm-project/commit/71dbd864f19f8b372f857b5322d3324240a17b89
DIFF: https://github.com/llvm/llvm-project/commit/71dbd864f19f8b372f857b5322d3324240a17b89.diff

LOG: [llvm-mc] Fix line_end_with_space.test

Currently, this test doesn't test what it was originally intended to
(that lvm-mc doesn't crash when disassembling a line that ends with a
space). This patch readds the space to the input so that this
functionality is actually tested and adds a comment describing what the
test does. The space seems to have been inadvertently removed in
c8d578311473fceb50579906658b0c017ef5b193 and then never added back
in.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D147207

Added: 
    

Modified: 
    llvm/test/tools/llvm-mc/line_end_with_space.test

Removed: 
    


################################################################################
diff  --git a/llvm/test/tools/llvm-mc/line_end_with_space.test b/llvm/test/tools/llvm-mc/line_end_with_space.test
index 673d05a68067c..5ad5a8382edfa 100644
--- a/llvm/test/tools/llvm-mc/line_end_with_space.test
+++ b/llvm/test/tools/llvm-mc/line_end_with_space.test
@@ -1 +1,3 @@
-RUN: llvm-mc -disassemble %s
+# Test that llvm-mc doesn't crash when disassembling a line that ends with a
+# space.
+RUN: echo -n ' ' | llvm-mc -disassemble


        


More information about the llvm-commits mailing list