[PATCH] D146057: [CodeGen] Speedup stack slot sharing during stack coloring (interval overlapping test).

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/StackSlotColoring.cpp:101-103
+      // LiveIntervalUnion has a parameter in its constructor so doing this
+      // dirty magic.
+      uint8_t LIUPad[sizeof(LiveIntervalUnion)];
----------------
I don't understand what this is doing, the parameter is just the allocator? Why can't you just normally construct a LiveIntervalUnion without placement new?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146057/new/

https://reviews.llvm.org/D146057