[PATCH] D147143: Add backend support for new PAL ELF Metadata 3.0

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:582-602
+    OutStreamer->emitRawComment(" COMPUTE_PGM_RSRC2:SCRATCH_EN: " +
+                                    Twine(CurrentProgramInfo.ScratchEnable),
+                                false);
+    OutStreamer->emitRawComment(" COMPUTE_PGM_RSRC2:USER_SGPR: " +
+                                    Twine(CurrentProgramInfo.UserSGPR),
+                                false);
+    OutStreamer->emitRawComment(" COMPUTE_PGM_RSRC2:TRAP_HANDLER: " +
----------------
This is a bunch of pure formatting changes that can be pre-committed?


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1063-1069
+      // The front-end will set tgid_x/y/z_en - just check for consistency
+      assert(MD->checkComputeRegisters(".tgid_x_en",
+                                       (bool)CurrentProgramInfo.TGIdXEnable));
+      assert(MD->checkComputeRegisters(".tgid_y_en",
+                                       (bool)CurrentProgramInfo.TGIdYEnable));
+      assert(MD->checkComputeRegisters(".tgid_z_en",
+                                       (bool)CurrentProgramInfo.TGIdZEnable));
----------------
Don't understand the assert or the comment. We infer these off, but are you suggesting something else is ignoring that?


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1096
+      // Set PsInputEna and PsInputAddr .spi_ps_input_ena and .spi_ps_input_addr
+      const char *PsInputFields[] = {
+          ".persp_sample_ena",    ".persp_center_ena",
----------------
static const StringLiteral table?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147143/new/

https://reviews.llvm.org/D147143