[PATCH] D146325: [PowerPC] Add statistics to show the number of entries in the TOC.
Amy Kwan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 31 11:06:02 PDT 2023
amyk accepted this revision as: amyk.
amyk added a comment.
This revision is now accepted and ready to land.
Thanks for addressing my comments. I don't have any further comments but I just had one clarification question.
Other than that, the patch LGTM.
================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:2900
+ MCSymbol *TOCEntry =
+ lookUpOrCreateTOCEntry(TypeInfoSym, TOCType_GlobalInternal);
const MCSymbol *TOCBaseSym =
----------------
I might be missing something but how do we know that the type will be `TOCType_GlobalInternal`?
I realized I am not quite sure what the `TType` means.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146325/new/
https://reviews.llvm.org/D146325
More information about the llvm-commits
mailing list