[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

Fri Mar 31 10:03:46 PDT 2023

probinson added subscribers: debug-info, probinson.
probinson added a comment.

I think we cannot be 100% sure about source paths in a cross-compile situation. Cross-compiling on platform A targeting platform B does not mean your sources and debugger UI are on platform B. My users keep source and debugger UI on platform A, debugging target B remotely. We need to preserve the host pathnames. It is not clear to me that this patch does so.

================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:787

   StringRef PathRef(Asm->TM.Options.ObjectFilenameForDebug);
   llvm::SmallString<256> PathStore(PathRef);
----------------
zequanwu wrote:
> hans wrote:
> > This handles codeview. Does anything need to be done for dwarf on windows? mstorsjo might have input on that.
> It looks like `TM.Options.ObjectFilenameForDebug` is only used for codeview. I guess dwarf doesn't store the object file path.
Right, DWARF only stores the source path.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147256/new/

https://reviews.llvm.org/D147256